boyscout: clean up ootr example #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clean up ootr example for the Brussels demo: - do not return (), if something is void it doesn't matter what is the last expression, it knows it has to return void - remove re-definition of i to i + 1, we can do this inside the while loop - remove N = i + 503
| cur = first | ||
| in { | ||
| while (i < N) { | ||
| i = i + 1; | ||
| next = new Agent(i); | ||
| cur.setNext(next); |
There was a problem hiding this comment.
@albertnetymk is there any reason why we want to use . instead of !?
|
If I'm not mistaken, there's no reason to ever use If the above sentence is correct, we could actually emit a compiler warning or even automatically translate the dot to a bang. |
|
The final version of method calls should probably not use "!". One can infer (easily) whether the resulting future is required. |
|
|
albertnetymk
added a commit
that referenced
this pull request
Feb 22, 2015
boyscout: clean up ootr example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean up
ootrexample for the Brussels demo:(), if something returnsvoidit doesn't matterwhat is the last expression, it knows it has to return
voiditoi + 1, we can do this insidethe
whileloopN = i + 503