Fix tracing for future value. #166
Conversation
| @@ -88,17 +88,12 @@ struct future | |||
| future_t *parent; | |||
| closure_entry_t *children; | |||
| actor_list *awaited_actors; | |||
| future_t *next; | |||
There was a problem hiding this comment.
the PR seems ok. I would only argue that we are adding the pointer next because it's needed by the actor that creates a linked list of futures. Futures per se don't need this pointer in the sense that this is bookkeeping of the actor to gc the future.
I believe it could be better if we create a simple linked list structure
that gets added to the actor fields, instead of the fut* my_future, and a couple of operations to go back and forth in the list (your future_set_next() and future_get_next()). This will give us a better separation of concerns since, as mentioned before, futures do not need to do any bookkeeping, it's the actors that need to.
Opinions on this are welcome. If no one replies before the Hackathon, I'll merge it
|
|
Disabled `largestream`, for it causes stack overflow, which, I believe, is fixed in the upstream. Disabled `async_force_gc` and `async_foreach`, for the fix is on the way.
|
Reviewer: Planning to merge this one? Any objections? |
|
Author of this PR: One second, needs to be rebased. |
|
Author of this PR: Rebased, good to go. |
Fix tracing for future value.
No description provided.