Pass program source file to test.sh in basic.
#178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After stripping the suffix, some programs' names are prefix of others. eg. async (async.enc) is the prefix of async_block (async_block.enc), which confuses the skipping process in `test.sh`.
| @@ -48,11 +48,12 @@ passed=0 | |||
| failed=0 | |||
| failed_list=() | |||
|
|
|||
| # skipped=(async.enc) | |||
There was a problem hiding this comment.
This line could be removed -- perhaps replaced by a comment stating what the purpose of skipped is.
There was a problem hiding this comment.
It's kept there on purpose to show the format how it's used. I thought the name skipped is self-documenting.
supercooldave
pushed a commit
that referenced
this pull request
May 30, 2015
Pass program source file to `test.sh` in basic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After stripping the suffix, some programs' names are prefix of others.
eg. async (async.enc) is the prefix of async_block (async_block.enc),
which confuses the skipping process in
test.sh.