Separate resolveType and checking for recursion #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors `resolveType` so that the checking for recursive type synonyms is not done for every lookup. This allows it to be lifted out of the state monad (which is the main reason for this refactoring). Instead there is a function `resolveTypeAndCheckForLoops` that does what `resolveType` did before, and this function is called when prechecking a type synonym. This is done with minimal code duplication by also refactoring resolving of ref types into its own function.
|
Funny, I did something very similar but it looped. Yours doesn't seem to loop. Bravo. |
|
I have tested with the issue #413 . I works perfectly. Can I merge by 13:00 today if there is not any objection? |
added 2 commits
May 13, 2016 09:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors
resolveTypeso that the checking for recursivetype synonyms is not done for every lookup. This allows it to be lifted
out of the state monad (which is the main reason for this refactoring).
Instead there is a function
resolveTypeAndCheckForLoopsthat does whatresolveTypedid before, and this function is called when prechecking atype synonym. This is done with minimal code duplication by also
refactoring resolving of ref types into its own function.
Also fixes issue #413.