Let pretty printing use OverloadedStrings #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "bool" | ||
| "char" | ||
| "int" | ||
| "string" |
There was a problem hiding this comment.
I believe that string has been deprecated
There was a problem hiding this comment.
Yes, and we still give a warning when using that type! When it's completely removed from the compiler, the emacs-mode could also drop it.
There was a problem hiding this comment.
...on second thought, maybe the Emacs mode shouldn't encourage using string if it's deprecated!
There was a problem hiding this comment.
I need to rebase anyway, so I'll remove this in the process.
|
apart from those two small comments, I am merging this as soon as it is rebased |
This commit refactors the pretty printing of C and Encore ASTs, mainly by using [OverloadedStrings](https://www.schoolofhaskell.com/school/to-infinity-and-beyond/pick-of-the-week/guide-to-ghc-extensions/basic-syntax-extensions#overloadedstrings). This GHC extension lets you use string literals where another `String` like data-type is expected. The pretty printers work with the type `Doc`, meaning we had to write `text "*"` when we wanted a literal `"*"`. Now, the string literal is enough. Also cleaned up parts of the code and made the emacs mode more resilent to change.
|
Fixed and rebased! |
|
Merging in 15 min |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the pretty printing of C and Encore ASTs, mainly
by using OverloadedStrings. This GHC extension lets you use string literals
where another
Stringlike data-type is expected. The pretty printerswork with the type
Doc, meaning we had to writetext "*"when wewanted a literal
"*". Now, the string literal is enough. Also cleaned upparts of the code and made the emacs mode more resilent to change.