Transform HTML prior to collecting dependencies (#483)

* Failing test case for assets in posthtml include The same issue exists for posthtml-extend. * Transform HTML prior to collecting dependencies Until HTML is transformed, some dependencies may not be visible. * Remove post collection HTML transform As recommended by @devongovett and @shawwn in Slack
parcel-bundler · Jan 4, 2018 · 2fbba62 · 2fbba62
1 parent e09575d
commit 2fbba62
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 1 deletion.
diff --git a/src/assets/HTMLAsset.js b/src/assets/HTMLAsset.js
@@ -61,7 +61,7 @@ class HTMLAsset extends Asset {
     });
   }
 
-  async transform() {
+  async pretransform() {
     await posthtmlTransform(this);
   }
 

diff --git a/test/html.js b/test/html.js
@@ -61,6 +61,22 @@ describe('html', function() {
     assert(html.includes('<h1>Other page</h1>'));
   });
 
+  it('should find assets inside posthtml', async function() {
+    let b = await bundle(__dirname + '/integration/posthtml-assets/index.html');
+
+    assertBundleTree(b, {
+      name: 'index.html',
+      assets: ['index.html'],
+      childBundles: [
+        {
+          type: 'js',
+          assets: ['index.js'],
+          childBundles: []
+        }
+      ]
+    });
+  });
+
   it('should insert sibling CSS bundles for JS files in the HEAD', async function() {
     let b = await bundle(__dirname + '/integration/html-css/index.html');
 

diff --git a/test/integration/posthtml-assets/.posthtmlrc.js b/test/integration/posthtml-assets/.posthtmlrc.js
@@ -0,0 +1,7 @@
+module.exports = {
+  plugins: {
+    "posthtml-include": {
+      root: __dirname
+    }
+  }
+};
diff --git a/test/integration/posthtml-assets/index.html b/test/integration/posthtml-assets/index.html
@@ -0,0 +1,6 @@
+<!doctype html>
+<html>
+<body>
+    <include src="other.html"></include>
+</body>
+</html>
diff --git a/test/integration/posthtml-assets/index.js b/test/integration/posthtml-assets/index.js
@@ -0,0 +1 @@
+window.alert("Hello world!");
diff --git a/test/integration/posthtml-assets/other.html b/test/integration/posthtml-assets/other.html
@@ -0,0 +1,2 @@
+<h1>Other page</h1>
+<script src="index.js"></script>
-Original file line number
+Diff line change
@@ Expand Up / @@ -61,7 +61,7 @@ class HTMLAsset extends Asset { @@
         });
       }
-      async transform() {
+      async pretransform() {
         await posthtmlTransform(this);
       }
@@ Expand Down @@
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		<h1>Other page</h1>
		<script src="index.js"></script>