Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update postcss and deps #2203

Merged
merged 4 commits into from
Oct 27, 2018
Merged

update postcss and deps #2203

merged 4 commits into from
Oct 27, 2018

Conversation

thisconnect
Copy link
Contributor

@thisconnect thisconnect commented Oct 26, 2018 •
edited
Loading

↪️ Pull Request

postcss-preset-env from version 6.x requires postcss 7.x

this PR updates postcss + deps and did pass yarn test locally fingers crossed it passes CI too

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • [x ] Added/updated unit tests for this change
  • [? ] Filled out test instructions (In case there aren't any unit tests)
  • [x ] Included links to related issues/PRs

DeMoorJasper
DeMoorJasper requested changes Oct 26, 2018
View reviewed changes
Copy link
Member

@DeMoorJasper DeMoorJasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the node 6 tests that fail due to this PR

@thisconnect
Copy link
Contributor Author

thank you for helping

@DeMoorJasper DeMoorJasper merged commit 494e52d into parcel-bundler:master Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeMoorJasper DeMoorJasper DeMoorJasper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thisconnect @DeMoorJasper