Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope Hoisting: Throw meaningful error on undefined exports #2693

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Scope Hoisting: Throw meaningful error on undefined exports #2693

merged 1 commit into from
Mar 6, 2019

Conversation

mischnic
Copy link
Member

↪️ Pull Request

Previously:
lib2.js: Cannot read property 'constantViolations' of undefined
Now:
lib2.js: export 'Multiply' is not defined

💻 Examples

export {Multiply};

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@mischnic mischnic changed the title Throw meaningful error on undefined exports Scope Hoisting: Throw meaningful error on undefined exports Feb 27, 2019
@devongovett devongovett merged commit 2a55296 into master Mar 6, 2019
@devongovett devongovett deleted the scope-hoisting-undefined-export branch March 6, 2019 04:27
@lukyth lukyth mentioned this pull request Mar 25, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeMoorJasper DeMoorJasper DeMoorJasper approved these changes

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mischnic @devongovett @DeMoorJasper