Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parenthesis around $parcel$interopDefault call for externals #7113

Merged
merged 5 commits into from
Oct 26, 2021

Conversation

mischnic
Copy link
Member

Closes #7111

Previously, parenthesis were missing:

new $parcel$interopDefault($lKLz7$test)()

@height
Copy link

height bot commented Oct 17, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Oct 17, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.95s -30.00ms
Cached 313.00ms +23.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 578.00ms -45.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 579.00ms -45.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 579.00ms -45.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 624.00ms +66.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 624.00ms +65.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 624.00ms +65.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 10.26s +52.00ms
Cached 459.00ms -25.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.09m -1.68s
Cached 1.76s -95.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/editorView.8daeea01.js 594.83kb +0.00b 37.14s -13.90s 🚀
dist/popup.64bc9a82.js 209.67kb +0.00b 37.14s -13.90s 🚀
dist/Toolbar.e3ba4416.js 107.23kb +0.00b 37.14s -13.90s 🚀
dist/Modal.cd71eaf3.js 45.33kb +0.00b 37.14s -13.90s 🚀
dist/js.660b75db.js 17.25kb +0.00b 37.14s -13.90s 🚀
dist/ui.5d3f7adc.js 14.94kb +0.00b 37.14s -13.90s 🚀
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 37.14s -13.90s 🚀
dist/dropzone.e0209bf8.js 12.15kb +0.00b 37.14s -13.90s 🚀
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 37.14s -13.90s 🚀
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 37.14s -13.90s 🚀
dist/dropzone.55bef257.js 3.29kb +0.00b 37.14s -13.90s 🚀
dist/clipboard.df70240c.js 2.93kb +0.00b 37.14s -13.90s 🚀
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 37.14s -13.90s 🚀
dist/browser.4e039ed7.js 1.69kb +0.00b 37.14s -13.90s 🚀
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 37.14s -13.90s 🚀
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 37.14s -13.90s 🚀
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 37.14s -13.90s 🚀

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 7.09s -70.00ms
Cached 397.00ms -50.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/Three.js 579.68kb +0.00b 5.06s -351.00ms 🚀

Click here to view a detailed benchmark overview.

@mischnic mischnic requested a review from devongovett October 25, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong compile
3 participants