Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to sync engines with core version #7207

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Add script to sync engines with core version #7207

merged 2 commits into from
Nov 2, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Oct 27, 2021 •
edited
Loading

Closes #6854

> require("semver").satisfies("2.0.0-nightly.893+da998f75", "^2.0.0")
false
> require("semver").satisfies("2.0.0-nightly.893+da998f75", "2.0.0-nightly.893")
true
> require("semver").satisfies("2.0.0-nightly.893+da998f75", "2.0.0-nightly.892")
false
  • The only question is when this should be called

@height
Copy link

height bot commented Oct 27, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Oct 27, 2021 •
edited
Loading

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.73s -6.00ms
Cached 267.00ms -6.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 519.00ms -36.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 520.00ms -36.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 520.00ms -36.00ms 🚀

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 9.09s -171.00ms
Cached 425.00ms -9.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 59.49s -208.00ms
Cached 1.62s +25.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.f0cb9522.js 693.77kb +0.00b 33.73s -11.81s 🚀
dist/editorView.af442747.js 594.92kb +0.00b 33.73s -11.42s 🚀
dist/popup.64bc9a82.js 209.67kb +0.00b 33.73s -11.42s 🚀
dist/index.87a1d973.js 145.62kb +0.00b 33.73s -11.81s 🚀
dist/Toolbar.e3ba4416.js 107.23kb +0.00b 33.73s -11.42s 🚀
dist/card.8ef34b4f.js 62.67kb +0.00b 33.73s -11.81s 🚀
dist/Modal.cd71eaf3.js 45.33kb +0.00b 33.73s -11.42s 🚀
dist/js.660b75db.js 17.25kb +0.00b 33.73s -11.42s 🚀
dist/ui.5d3f7adc.js 14.94kb +0.00b 33.74s -11.41s 🚀
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 33.73s -11.42s 🚀
dist/dropzone.e0209bf8.js 12.15kb +0.00b 33.73s -11.42s 🚀
dist/card.26823fa1.js 5.77kb +0.00b 33.73s -11.81s 🚀
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 33.74s -11.41s 🚀
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 33.73s -11.42s 🚀
dist/dropzone.55bef257.js 3.29kb +0.00b 33.73s -11.42s 🚀
dist/Modal.ecafad9e.js 3.15kb +0.00b 33.73s -11.81s 🚀
dist/clipboard.df70240c.js 2.93kb +0.00b 33.73s -11.42s 🚀
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 33.74s -11.41s 🚀
dist/browser.4e039ed7.js 1.69kb +0.00b 33.73s -11.42s 🚀
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 33.73s -11.42s 🚀
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 33.73s -11.42s 🚀
dist/media-card-analytics-error-boundary.30f51dac.js 962.00b +0.00b 33.73s -11.81s 🚀
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 33.74s -11.41s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/EmojiPickerComponent.07ae4435.js 147.12kb +0.00b 28.22s +9.19s ⚠️
dist/esm.f1a592e5.js 33.15kb +0.00b 28.22s +9.19s ⚠️
dist/DatePicker.f2994e45.js 22.98kb +0.00b 28.22s +9.19s ⚠️
dist/js.660b75db.js 17.25kb +0.00b 45.66s +10.88s ⚠️
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 45.66s +10.88s ⚠️
dist/feedback.c7e69064.js 1.77kb +0.00b 28.22s +9.19s ⚠️
dist/workerHasher.3639b1f9.js 1.63kb +0.00b 28.22s +9.19s ⚠️
dist/heading6.a693146e.js 1.51kb +0.00b 28.22s +9.20s ⚠️
dist/heading5.8bfafe21.js 1.38kb +0.00b 28.22s +9.19s ⚠️
dist/expand.a44d10fe.js 1.29kb +0.00b 28.22s +9.19s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 6.30s +7.00ms
Cached 354.00ms +16.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic
Copy link
Member Author

mischnic commented Nov 2, 2021 •
edited
Loading

Every lerna publish step calls prepublishOnly, which is also how scripts/update-config-dependencies.js (to update parcelDependencies) was already called for nightly releases. So I just added this script there as well.

Also, all engines.parcel are now replaced with the corresponding @parcel/core version. For nightly and prereleases, it's an exact range and for normal releases a caret range

@mischnic mischnic marked this pull request as ready for review November 2, 2021 19:27
@mischnic mischnic requested a review from devongovett November 2, 2021 19:27
@devongovett devongovett merged commit d4b4256 into v2 Nov 2, 2021
@devongovett devongovett deleted the nightly-engines branch November 2, 2021 22:46
lettertwo added a commit that referenced this pull request Nov 3, 2021
@lettertwo
Merge branch 'v2' into lettertwo/cache-large-blob
28c5b66 
* v2:
  Add script to sync engines with core version (#7207)
lettertwo added a commit that referenced this pull request Nov 15, 2021
@lettertwo
Merge branch 'v2' into lettertwo/buffer-backed-graph
4f219c8 
* v2: (68 commits)
  Fix RangeError in `not export` error with other file type (#7295)
  Apply sourcemap in @parcel/transformer-typescript-tsc (#7287)
  Fix side effects glob matching (#7288)
  Fix changelog headings
  v2.0.1
  Changelog for v2.0.1
  Resolve GLSL relative to the importer, not the asset (#7263)
  fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248)
  Fixed missing "Parcel" export member in Module "@parcel/core" (#7250)
  Add script to sync engines with core version (#7207)
  Bump swc (#7216)
  Make Webpack loader detection regex dramatically faster (#7226)
  swc optimizer (#7212)
  Update esbuild in optimizer (#7233)
  Properly visit member expressions (#7228)
  Update to prettier 2 (#7209)
  Fix serve mode with target override and target source fields (#7187)
  Update package.json to include the repository (#7184)
  fix #6730: add transformer-raw as dependency of config-webextension (#7193)
  Log warning instead of crash if image optimizer fails (#7119)
  ...
lettertwo added a commit that referenced this pull request Nov 15, 2021
@lettertwo
Merge branch 'v2' into lettertwo/buffer-backed-graph
73cf858 
* v2: (68 commits)
  Fix RangeError in `not export` error with other file type (#7295)
  Apply sourcemap in @parcel/transformer-typescript-tsc (#7287)
  Fix side effects glob matching (#7288)
  Fix changelog headings
  v2.0.1
  Changelog for v2.0.1
  Resolve GLSL relative to the importer, not the asset (#7263)
  fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248)
  Fixed missing "Parcel" export member in Module "@parcel/core" (#7250)
  Add script to sync engines with core version (#7207)
  Bump swc (#7216)
  Make Webpack loader detection regex dramatically faster (#7226)
  swc optimizer (#7212)
  Update esbuild in optimizer (#7233)
  Properly visit member expressions (#7228)
  Update to prettier 2 (#7209)
  Fix serve mode with target override and target source fields (#7187)
  Update package.json to include the repository (#7184)
  fix #6730: add transformer-raw as dependency of config-webextension (#7193)
  Log warning instead of crash if image optimizer fails (#7119)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@parcel/core: The plugin "@parcel/packager-svg" is not compatible with the current version of Parcel.
3 participants
@mischnic @parcel-benchmark @devongovett