Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original filepath instead of current type for config.searchPath #7448

Merged
merged 3 commits into from
Dec 28, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Dec 14, 2021

@height
Copy link

height bot commented Dec 14, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@mischnic mischnic changed the title Use original filepath instead of current type for config Use original filepath instead of current type for config.searchPath Dec 14, 2021
@parcel-benchmark
Copy link

parcel-benchmark commented Dec 14, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.71s -34.00ms
Cached 323.00ms +22.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 484.00ms -42.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 485.00ms -42.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 485.00ms -41.00ms 🚀
dist/legacy/index.0a5c751e.js 1.59kb +0.00b 723.00ms -52.00ms 🚀
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 723.00ms -52.00ms 🚀
dist/modern/index.6be20f01.js 1.13kb +0.00b 723.00ms -51.00ms 🚀
dist/legacy/index.html 826.00b +0.00b 839.00ms -45.00ms 🚀
dist/modern/index.html 749.00b +0.00b 839.00ms -45.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 523.00ms +50.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 528.00ms +54.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 528.00ms +53.00ms ⚠️
dist/legacy/index.0a5c751e.js 1.59kb +0.00b 766.00ms +73.00ms ⚠️
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 766.00ms +73.00ms ⚠️
dist/modern/index.6be20f01.js 1.13kb +0.00b 766.00ms +72.00ms ⚠️
dist/legacy/index.html 826.00b +0.00b 886.00ms +78.00ms ⚠️
dist/modern/index.html 749.00b +0.00b 885.00ms +78.00ms ⚠️
dist/legacy/index.c1bc86aa.css 94.00b +0.00b 991.00ms +86.00ms ⚠️
dist/modern/index.57a95cbe.css 94.00b +0.00b 991.00ms +86.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 8.51s -158.00ms
Cached 416.00ms -3.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 59.22s +2.39s
Cached 1.46s -56.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.e37648e2.js 1.78mb +0.00b 17.07s +1.15s ⚠️
dist/editorView.124f5fc0.js 594.92kb +0.00b 33.33s -9.78s 🚀
dist/popup.64bc9a82.js 209.67kb +0.00b 33.33s -9.77s 🚀
dist/EmojiPickerComponent.922af3e4.js 147.13kb +0.00b 28.01s +10.45s ⚠️
dist/Toolbar.1af0e801.js 107.23kb +0.00b 33.33s -9.78s 🚀
dist/Modal.cd71eaf3.js 45.33kb +0.00b 33.33s -9.77s 🚀
dist/component.5b4e4410.js 37.35kb +0.00b 17.07s +1.15s ⚠️
dist/esm.f1a592e5.js 33.15kb +0.00b 28.01s +10.45s ⚠️
dist/component.741edbc5.js 24.94kb +0.00b 17.07s +1.15s ⚠️
dist/DatePicker.f2994e45.js 22.98kb +0.00b 28.01s +10.45s ⚠️
dist/js.660b75db.js 17.25kb +0.00b 44.60s +12.23s ⚠️
dist/ui.5d3f7adc.js 14.94kb +0.00b 33.34s -9.77s 🚀
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 33.33s -9.78s 🚀
dist/dropzone.39132d0c.js 12.16kb +0.00b 33.33s -9.77s 🚀
dist/component.598bf511.js 6.83kb +0.00b 16.88s +980.00ms ⚠️
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 33.33s -9.77s 🚀
dist/png-chunks-extract.5c9c0fb9.js 3.58kb +0.00b 44.60s +12.23s ⚠️
dist/dropzone.55bef257.js 3.29kb +0.00b 33.33s -9.77s 🚀
dist/clipboard.df70240c.js 2.93kb +0.00b 33.33s -9.77s 🚀
dist/16.4e6ce5ae.js 2.35kb +0.00b 17.07s +1.15s ⚠️
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 33.34s -9.77s 🚀
dist/date.ada90b9d.js 1.87kb +0.00b 17.07s +1.15s ⚠️
dist/feedback.c7e69064.js 1.77kb +0.00b 28.01s +10.45s ⚠️
dist/16.f9bcc218.js 1.74kb +0.00b 16.88s +980.00ms ⚠️
dist/browser.4e039ed7.js 1.69kb +0.00b 33.33s -9.77s 🚀
dist/16.8cacdd41.js 1.67kb +0.00b 16.88s +981.00ms ⚠️
dist/workerHasher.3639b1f9.js 1.63kb +0.00b 28.01s +10.45s ⚠️
dist/code.00826c30.js 1.51kb +0.00b 17.07s +1.15s ⚠️
dist/heading6.a693146e.js 1.51kb +0.00b 28.01s +10.45s ⚠️
dist/16.3ea64ad5.js 1.39kb +0.00b 16.88s +979.00ms ⚠️
dist/heading5.8bfafe21.js 1.38kb +0.00b 28.01s +10.45s ⚠️
dist/16.dde66fb5.js 1.34kb +0.00b 16.88s +981.00ms ⚠️
dist/16.17fccf53.js 1.34kb +0.00b 16.88s +981.00ms ⚠️
dist/16.e572fbc0.js 1.32kb +0.00b 16.88s +979.00ms ⚠️
dist/16.82436cab.js 1.32kb +0.00b 16.88s +979.00ms ⚠️
dist/expand.a44d10fe.js 1.29kb +0.00b 28.01s +10.45s ⚠️
dist/16.bbe3d65c.js 1.28kb +0.00b 16.88s +980.00ms ⚠️
dist/16.da4ba1b5.js 1.24kb +0.00b 16.88s +980.00ms ⚠️
dist/16.5076785a.js 1.21kb +0.00b 16.88s +980.00ms ⚠️
dist/16.b2ed99cf.js 1.20kb +0.00b 16.88s +980.00ms ⚠️
dist/16.7d56994f.js 1.19kb +0.00b 16.88s +979.00ms ⚠️
dist/16.4788b572.js 1.15kb +0.00b 16.88s +980.00ms ⚠️
dist/16.f98e3014.js 1.15kb +0.00b 16.88s +980.00ms ⚠️
dist/16.10f72c3a.js 1.14kb +0.00b 16.88s +981.00ms ⚠️
dist/16.d0a606ba.js 1.14kb +0.00b 16.88s +981.00ms ⚠️
dist/16.75f3718c.js 1.14kb +0.00b 16.88s +979.00ms ⚠️
dist/action.0ca21388.js 1.14kb +0.00b 17.07s +1.15s ⚠️
dist/16.a1253273.js 1.14kb +0.00b 16.88s +981.00ms ⚠️
dist/component.6377d10b.js 1.13kb +0.00b 17.07s +1.15s ⚠️
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 33.33s -9.77s 🚀
dist/16.70992eab.js 1.10kb +0.00b 16.88s +980.00ms ⚠️
dist/16.dbb3595d.js 1.06kb +0.00b 16.88s +980.00ms ⚠️
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 33.33s -9.77s 🚀
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 33.33s -9.77s 🚀

Cached Bundles

No bundle changes detected.

Three.js ✅

Timings

Description Time Difference
Cold 6.32s -31.00ms
Cached 364.00ms +8.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic force-pushed the config-seachpath-type branch from 009577f to 27ffd2a Compare December 17, 2021 19:16
@mischnic mischnic requested a review from devongovett December 17, 2021 19:17
@mischnic mischnic marked this pull request as ready for review December 17, 2021 19:17
@devongovett devongovett merged commit f094a8e into v2 Dec 28, 2021
@devongovett devongovett deleted the config-seachpath-type branch December 28, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants