Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to define the "compilerOptions" of the VueTransformer #8031

Merged
merged 2 commits into from
May 4, 2022
Merged

Allow to define the "compilerOptions" of the VueTransformer #8031

merged 2 commits into from
May 4, 2022

Conversation

abellion
Copy link
Contributor

↪️ Pull Request

Fixes #8030

@101arrowz
Copy link
Member

101arrowz commented May 1, 2022 •
edited
Loading

Many of the compiler options can't be made in pure JSON, which means you need a JS config file. This includes isCustomElement. As a result caching will suffer substantially. Nonetheless this is probably a worthwhile change.

We might want to look into ways to declare invalidators within config files (i.e. an exported invalidateConfig function that prevents busting the cache when nothing relevant changes).

@abellion
Copy link
Contributor Author

abellion commented May 2, 2022

Yep, true. However, as the Vue config can also come from JS files (.vuerc.js, vue.config.js), I think people won't try to configure what's not configurable though JSON (e.g. the isCustomElement setting).

@mischnic mischnic merged commit 019b7cb into parcel-bundler:v2 May 4, 2022
@abellion abellion deleted the patch-1 branch May 4, 2022 08:32
@KaKi87
Copy link

KaKi87 commented Aug 6, 2022

Hello,

the Vue config can also come from JS files (.vuerc.js, vue.config.js), I think people won't try to configure what's not configurable though JSON (e.g. the isCustomElement setting).

How to make Parcel handle either of those files using the programmatic API (await new Parcel(...).watch() for dev & await new Parcel(...).run() for prod) ?

Thanks

gorakong pushed a commit that referenced this pull request Nov 3, 2022
@lettertwo
Merge 'upstream/v2' into wbinnssmith/merge-v2-2022-04-22
8e13ce5 
* upstream/v2:
  fix: getNodeIdsConnected should remove duplicate values (#8054)
  chore: should log unsupported type not zero and toLocaleString's option typo (#8002)
  Allow animated images (#8018)
  Add "key" and "update_url" to webextension manifest schema (#8043)
  Allow to define the "compilerOptions" of the VueTransformer (#8031)
  fix(image transformer): Update supported formats (#8028)
  support for `oauth2` field in mv3 (#8037)
  Update @parcel/css to 1.8.2 (#8044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@101arrowz 101arrowz 101arrowz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vue.js transformer is missing the "isCustomElement" option
4 participants
@abellion @101arrowz @KaKi87 @mischnic