Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register swc error handler #8032

Merged
merged 3 commits into from
May 1, 2022
Merged

Register swc error handler #8032

merged 3 commits into from
May 1, 2022

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Apr 30, 2022 •
edited
Loading

Hide whitespace changes when viewing diff

Register swc error handler to propagate errors generated during transpilation instead of panicing.

Reported in #6605 (comment)
And also #7234

@parcel-benchmark
Copy link

parcel-benchmark commented Apr 30, 2022 •
edited
Loading

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 11.20s -133.00ms
Cached 516.00ms -19.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.93m -682.00ms
Cached 3.13s -40.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/16.069344b7.js 905.00b +0.00b 42.88s -4.68s 🚀
dist/simpleHasher.46d6f2e5.js 742.00b +0.00b 47.55s -40.01s 🚀
dist/index.html 240.00b +0.00b 37.81s -3.78s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/esm.6190c9ac.js 61.54kb +0.00b 1.45m +39.25s ⚠️
dist/workerHasher.e50d242f.js 1.72kb +0.00b 1.45m +39.25s ⚠️
dist/16.1969624f.js 1.08kb +0.00b 46.99s +3.60s ⚠️
dist/16.069344b7.js 905.00b +0.00b 46.99s +3.60s ⚠️
dist/simpleHasher.46d6f2e5.js 742.00b +0.00b 1.45m +39.25s ⚠️
dist/index.html 240.00b +0.00b 1.45m +49.05s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 8.14s -78.00ms
Cached 335.00ms +15.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic force-pushed the swc-error-handler branch from c88abb2 to 3a5b8f4 Compare April 30, 2022 19:33
@mischnic mischnic merged commit c576758 into v2 May 1, 2022
@mischnic mischnic deleted the swc-error-handler branch May 1, 2022 17:08
@harryhjsh harryhjsh mentioned this pull request May 9, 2022
Closed
gorakong pushed a commit that referenced this pull request Nov 3, 2022
@lettertwo
Merge remote-tracking branch 'upstream/v2' into wbinnssmith/merge-v2-…
56c5965 
…2022-04-22

* upstream/v2:
  Register swc error handler (#8032)
  Correctly emit warnings for unnecessary PostCSS plugins in package.json (#8024)
  Pass targets for swc/helpers to Rust and only filter them for preset env (#8020)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mischnic @parcel-benchmark @devongovett