Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parcel-query #9425

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix parcel-query #9425

merged 1 commit into from
Dec 7, 2023

Conversation

irismoini
Copy link
Contributor

@irismoini irismoini commented Dec 7, 2023

↪️ Pull Request

This PR fixes an existing bug in Parcel-query. Parcel-query currently fails with the following error due to recent changes to requestTypes. See #9412

Loading graphs...
node:internal/process/promises:279
            triggerUncaughtException(err, true /* fromPromise */);
            ^

AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  loadLargeBlobRequestRequest(
  cache,
  bundleGraphRequestNode,
  cacheInfo,
  )

    at loadGraphs (/Users/imoini/Desktop/upstream/parcel/packages/dev/query/src/index.js:100:12)
    at run (/Users/imoini/Desktop/upstream/parcel/packages/dev/query/src/cli.js:42:5) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}

💻 Examples

NA

🚨 Test instructions

NA

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@irismoini irismoini self-assigned this Dec 7, 2023
@irismoini irismoini merged commit bad439d into v2 Dec 7, 2023
14 of 16 checks passed
@irismoini irismoini deleted the imoini/P2X-1155-bug-fix-for-parcel-query branch December 7, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants