Update docs for new CSS modules features #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mischnic
reviewed
May 24, 2022
src/languages/css.md
Outdated
| {% endsamplefile %} | ||
| {% endsample %} | ||
|
|
||
| To reference a global variable, use the `from global` syntax: |
There was a problem hiding this comment.
Is there a way to declare a global variable in a CSS module asset?
There was a problem hiding this comment.
no, you'd have to do it by importing a non-css module. I can note this
src/languages/css.md
Outdated
|
|
||
| {% warning %} | ||
|
|
||
| **Note**: CSS grid line names can be ambiguous due to automatic postfixing done by the browser, which generates line names ending with `-start` and `-end` for each grid template area. When using CSS grid, ensure that your `"pattern"` configuration ends with the `[local]` placeholder so that these references work correctly. |
There was a problem hiding this comment.
Nit: Doesn't parcel-css throw an error if the user didn't respect this? Then I'd rather phrase this as "When using CSS, your pattern configuation has to end ... "
src/languages/css.md
Outdated
| ### Enabling CSS modules globally | ||
|
|
||
| By default, CSS modules are only enabled for files ending with `.module.css`. All other CSS files are treated as global CSS by default. However, this can be overridden to enable CSS modules for all files by configuring `@parcel/transformer-css` in your project root `package.json`. | ||
| By default, CSS modules are only enabled for filenames ending with `.module.css`. All other CSS files are treated as global CSS by default. However, this can be overridden to enable CSS modules for all source files (i.e. not in `node_modules`) by configuring `@parcel/transformer-css` in your project root `package.json`. |
There was a problem hiding this comment.
How can CSS modules be enabled for a filename?
Maybe "for files whose name ends with"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for parcel-bundler/lightningcss#180, parcel-bundler/lightningcss#183, and parcel-bundler/parcel#8122