forked from paritytech/polkadot-sdk
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix
frame-benchmarking-cli
not buildable without rocksdb (paritytec…
…h#7263) ## Description The `frame-benchmarking-cli` crate has not been buildable without the `rocksdb` feature since version 1.17.0. **Error:** ```rust self.database()?.unwrap_or(Database::RocksDb), ^^^^^^^ variant or associated item not found in `Database` ``` This issue is also related to the `rocksdb` feature bleeding (paritytech#3793), where the `rocksdb` feature was always activated even when compiling this crate with `--no-default-features`. **Fix:** - Resolved the error by choosing `paritydb` as the default database when compiled without the `rocksdb` feature. - Fixed the issue where the `sc-cli` crate's `rocksdb` feature was always active, even compiling `frame-benchmarking-cli` with `--no-default-features`. ## Review Notes Fix the crate to be built without rocksdb, not intended to solve paritytech#3793. --------- Co-authored-by: command-bot <>
- Loading branch information
Showing
3 changed files
with
30 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
title: Fix `frame-benchmarking-cli` not buildable without rocksdb | ||
doc: | ||
- audience: Runtime Dev | ||
description: |- | ||
## Description | ||
|
||
The `frame-benchmarking-cli` crate has not been buildable without the `rocksdb` feature since version 1.17.0. | ||
|
||
**Error:** | ||
```rust | ||
self.database()?.unwrap_or(Database::RocksDb), | ||
^^^^^^^ variant or associated item not found in `Database` | ||
``` | ||
|
||
This issue is also related to the `rocksdb` feature bleeding (#3793), where the `rocksdb` feature was always activated even when compiling this crate with `--no-default-features`. | ||
|
||
**Fix:** | ||
- Resolved the error by choosing `paritydb` as the default database when compiled without the `rocksdb` feature. | ||
- Fixed the issue where the `sc-cli` crate's `rocksdb` feature was always active, even compiling `frame-benchmarking-cli` with `--no-default-features`. | ||
|
||
## Review Notes | ||
|
||
Fix the crate to be built without rocksdb, not intended to solve #3793. | ||
crates: | ||
- name: polkadot-node-metrics | ||
bump: patch | ||
- name: frame-benchmarking-cli | ||
bump: patch |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters