-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add macro attr with_extensions
#1380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me; the attribute works well :)
proc-macros/src/render_server.rs
Outdated
#parsing | ||
let _ = context.as_ref().#rust_method_name(pending, &ext, #params_seq); | ||
#sub_err::None | ||
if sub.with_extensions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you collapse the if
into else if
following the recommendation from clippy, otherwise LGTM
Nice work! May I ask when it'll approximately be released? :) |
We are "hoping" to get a new release out tomorrow |
Follow-up on #1306
Let's add on option to use
Extensions
in the API or not because it may be annoying to just mark it as used and would be nice not to break the previous API for existing users.