refactor(ws server): impl IdProvider for Box<T>
#684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdw
reviewed
Feb 1, 2022
jsdw
reviewed
Feb 1, 2022
jsdw
reviewed
Feb 1, 2022
niklasad1
changed the title
Box<dyn>IdProvider for Box<T>
niklasad1
commented
Feb 1, 2022
maciejhirsz
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
IdProviderforBox<T>to supportBox<dyn IdProvider>, in addition I also addedstd::fmt::Debugto the IdProvider.//cc @maciejhirsz
I had a look how difficult it would be to make this purely static dispatch because currently we pass
dyn IdProviderto the RpcModule if the call is a subscription,Then we would have to add a type param on
Methods,RpcModuleand related types and the only user-facing would be the theRpcModulewhich is a bit annoying but it would kill the extra indirection's. The benefit of this is that we could get rid of theArc<dyn IdProvider>toI: IdProviderand requireCloneon IdProvider.