-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[client]: improve batch request API #910
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
changed the title
[WIP]: improve client batch request API
improve client batch request API
Oct 21, 2022
niklasad1
changed the title
improve client batch request API
WIP: improve client batch request API
Oct 26, 2022
niklasad1
changed the title
WIP: improve client batch request API
[client]: improve batch request API
Oct 27, 2022
niklasad1
commented
Oct 27, 2022
jsdw
reviewed
Nov 3, 2022
jsdw
reviewed
Nov 3, 2022
jsdw
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, ncie one!
lexnv
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #909
After some discussions with Kian about the API in #909 it simply quite annoying for users to deal with i.e, to iterate over all responses to check whether it was successful but useful in some contexts such as if you want to exactly which requests failed.
After some suggestions by James, I reworked the API with an iterator-like API.
The responses still doesn't expose the request ID mainly because jsonrpsee controls the request IDs and changing that quite a big change and doesn't work well with the current
BatchRequestBuilder
.Thus, the only way to map the requests to reponses is to copy the batch request and then iterate over the
BatchResponse::into_iter
together to figure it which calls that failed such as:Ideally, the
BatchRequestBuilder
would inject the request IDs and allow users to add their own IDs but because we use the ID range as digest for each batch request it would make things harder.Thus, I think this is good enough API for now.