Fix limit prefix delete case #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheme
commented
Apr 4, 2020
ordian
reviewed
Apr 4, 2020
ordian
reviewed
Apr 4, 2020
ordian
reviewed
Apr 23, 2020
ordian
reviewed
Apr 23, 2020
Co-Authored-By: Andronik Ordian <[email protected]>
ordian
reviewed
Apr 23, 2020
…ange, but that is fine.
dvdplm
approved these changes
Apr 23, 2020
ordian
added a commit
that referenced
this pull request
May 5, 2020
* master: (56 commits) primitive-types: add no_std support for serde feature (#385) Add Rocksdb Secondary Instance Api (#384) kvdb-rocksdb: update rocksdb to 0.14 (#379) prepare releases for a few crates (#382) uint: fix UB in uint::from_big_endian (#381) Fix limit prefix delete case (#368) Add arbitrary trait implementation (#378) kvdb-rocksdb: optimize and rename iter_from_prefix (#365) bump parity-util-mem (#376) parity-util-mem: fix for windows (#375) keccak-hash: fix bench and add one for range (#372) [parity-crypto] Release 0.6.1 (#373) keccak-hash: bump version to 0.5.1 (#371) keccak-hash: add keccak256_range and keccak512_range functions (#370) Allow pubkey recovery for all-zero messages (#369) Delete by prefix operator in kvdb (#360) kvdb: no overlay (#313) Ban duplicates of parity-uil-mem from being linked into the same program (#363) Use correct license ID (#362) Memtest example for Rocksdb (#349) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR to delete by prefix contains an ordering error, this PR fixes that.
The test change in this PR shows the problematic case.
The pr make use of the existing iter by prefix iterator for the corner case in rocksdb, and change end_prefix api to be safest, so it breaks #365.
One of the corner case that may be tricky to implement in #365 is this one, basically iterating by prefix [255] with existing key [255, 255], [255, 255, 255] ... in the db.
Ok, I am wrong this should work without change (since #365 only change read opt to set upper bound).
So this only require changing the call to end_prefix in #365