Serde Serialize & Deserialize for BoundedBTreeMap #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Oct 6, 2024
ordian
approved these changes
Oct 6, 2024
Co-authored-by: ordian <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
|
Could you also bump the Cargo.toml version? Looks good otherwise. |
|
The tests are not compiling without serde features. To fix, you need to wrap them in cfg(feature = "serde") like here: parity-common/bounded-collections/src/bounded_btree_set.rs Lines 590 to 591 in 7c701c6 |
Okay hopefully all works well now 😅 Have run the tests from the github actions file locally so should work. |
ordian
reviewed
Oct 8, 2024
|
published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BoundedBTreeMap cannot currently be used for parachain genesis state due to missing implementations of Serde. This PR aims to resolve that, similar to BoundedVec and BoundedBTreeSet
Corresponding issue: #869