Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed-hash: remove byteorder feature #872

Merged
merged 5 commits into from
Oct 10, 2024
Merged

fixed-hash: remove byteorder feature #872

merged 5 commits into from
Oct 10, 2024

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Oct 8, 2024

  • remove byteorder feature
  • rename impl_ops_for_hash => impl_bit_ops_for_fixed_hash
  • remove impl_cmp_for_fixed_hash macro

@koushiro
Copy link
Contributor Author

koushiro commented Oct 8, 2024

@ordian PTAL

@koushiro koushiro changed the title fixed-hash: remove byteorder features fixed-hash: remove byteorder feature Oct 8, 2024
@ordian ordian added breaking-change Breaking change changelog Needs to be added to the changelog labels Oct 8, 2024
ordian
ordian approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes makes sense to me. unfortunately, they are semver breaking which will lead to version bump propagation everywhere

@koushiro
Copy link
Contributor Author

koushiro commented Oct 8, 2024

the changes makes sense to me. unfortunately, they are semver breaking which will lead to version bump propagation everywhere

I will submit a few more PRs after this, they will also result in breaking changes.

@ordian
Copy link
Member

ordian commented Oct 8, 2024

please also fix this:

parity-common/.github/workflows/ci.yml

Line 70 in 366a95c

run: cargo test -p fixed-hash --no-default-features --features='byteorder,rustc-hex'

@koushiro koushiro requested a review from a team as a code owner October 8, 2024 10:16
@koushiro koushiro mentioned this pull request Oct 8, 2024
Closed
@koushiro
Copy link
Contributor Author

koushiro commented Oct 9, 2024

@bkchr PTAL

@bkchr bkchr merged commit 85f813a into paritytech:master Oct 10, 2024
6 checks passed
@koushiro koushiro deleted the improve-fixed-hash branch October 10, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ordian ordian ordian approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
breaking-change Breaking change changelog Needs to be added to the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koushiro @ordian @bkchr