This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion for #13846 #7022
Merged
Companion for #13846 #7022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam0x17
added
A0-please_review
KiChjang
approved these changes
Apr 7, 2023
bkchr
approved these changes
Apr 10, 2023
|
remaining blocker for this is the Bernhard Schuster's expander crate still relies on syn 1.x in a way that is incompatible with our upgrade elsewhere. Reaching out to him to see if we can get it upgraded. Apparently we own it? |
|
bot rebase |
|
Rebased |
sam0x17
force-pushed
the
sam-globally-upgrade-syn-quote
branch
from
905ba55 to
2d1b463
Compare
(new version hasn't been released yet so using git)
sam0x17
force-pushed
the
sam-globally-upgrade-syn-quote
branch
from
2d1b463 to
d96a8e9
Compare
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Statuses failed for c3e29f1 |
|
It's really weird because this was green when I merged the main PR 10 mins ago. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
sam0x17
force-pushed
the
sam-globally-upgrade-syn-quote
branch
from
95b7cee to
0b840da
Compare
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion for paritytech/substrate#13846