Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Clears Old Storage for Session pallet #7132

Merged
merged 15 commits into from
Apr 27, 2023
Merged

Clears Old Storage for Session pallet #7132

merged 15 commits into from
Apr 27, 2023

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented Apr 25, 2023 •
edited
Loading

Fixes #4691

The old migration didn't clear the data properly. This PR adds a V2 to clear everything under Session::HistoricalSessions and Session::StoredRange

As discussed in paritytech/substrate#13997, this migration is added directly to Polkadot and Kusama.

@gupnik gupnik added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. T1-runtime This PR/Issue is related to the topic “runtime”. labels Apr 25, 2023
@paritytech-ci paritytech-ci requested review from a team April 25, 2023 04:21
@gupnik gupnik mentioned this pull request Apr 25, 2023
Closed
@paritytech-ci paritytech-ci requested a review from a team April 25, 2023 13:06
ordian
ordian reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Kusama?

@paritytech-ci paritytech-ci requested a review from a team April 25, 2023 13:43
@gupnik gupnik requested a review from bkchr April 26, 2023 04:01
@gupnik
Copy link
Contributor Author

gupnik commented Apr 26, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Apr 26, 2023 •
edited
Loading

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2732291 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 63-6df1201c-9d96-4d5a-8caf-0017cb451c80 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Apr 26, 2023

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2732291 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2732291/artifacts/download.

bkchr
bkchr approved these changes Apr 26, 2023
View reviewed changes
runtime/common/src/session/migration.rs Outdated
#[cfg(feature = "try-runtime")]
use sp_std::vec::Vec;

pub struct MigrateToV2<T>(sp_std::marker::PhantomData<T>);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is misleading and should get some docs on what it is doing.

@gupnik
Copy link
Contributor Author

gupnik commented Apr 27, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Apr 27, 2023 •
edited
Loading

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2739497 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-7db4655c-96ed-4299-b593-6b1beefae380 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Apr 27, 2023

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2739497 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2739497/artifacts/download.

@gupnik
Copy link
Contributor Author

gupnik commented Apr 27, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@gupnik
Copy link
Contributor Author

gupnik commented Apr 27, 2023

bot merge force

@paritytech-processbot paritytech-processbot bot merged commit ccffb73 into master Apr 27, 2023
@paritytech-processbot paritytech-processbot bot deleted the gupnik/session-pallet-migration branch April 27, 2023 04:32
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian left review comments

@bkchr bkchr bkchr approved these changes

@eskimor eskimor eskimor approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inaccessible data stored at session pallet
4 participants
@gupnik @eskimor @ordian @bkchr