Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Remove --binaryen-as-dependency #285

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Remove --binaryen-as-dependency #285

merged 2 commits into from
Apr 6, 2021

Conversation

cmichi
Copy link
Contributor

@cmichi cmichi commented Apr 6, 2021

Closes https://github.com/paritytech/ci_cd/issues/121.

I tested it locally via

docker build -t contracts-ci 
docker run -it contracts-ci
7ca83609797f:/builds# cargo-contract --version                            
cargo-contract 0.11.1-unknown-x86_64-linux-gnu

@cmichi cmichi requested a review from TriplEight April 6, 2021 10:53
TriplEight
TriplEight reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but what about

scripts/dockerfiles/ink-ci-linux/Dockerfile

Line 57 in 78637e6

cargo install --features binaryen-as-dependency cargo-contract && \
?

@TriplEight TriplEight merged commit 333c9b6 into master Apr 6, 2021
@TriplEight TriplEight deleted the cmichi-use-binaryen-package branch April 6, 2021 15:28
@cmichi cmichi mentioned this pull request Apr 7, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TriplEight TriplEight TriplEight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmichi @TriplEight