Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

contracts: Refactor trait Ext::*_storage_transparent functions #13594

Closed
athei opened this issue Mar 14, 2023 · 0 comments · Fixed by #13600
Closed

contracts: Refactor trait Ext::*_storage_transparent functions #13594

athei opened this issue Mar 14, 2023 · 0 comments · Fixed by #13600
Assignees
@pgherveou
Labels
Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.

Comments

@athei
Copy link
Member

athei commented Mar 14, 2023 •
edited
Loading

Those functions are identical with their non-transparent counterparts. This is a nuisance we want to get rid of. We can unify them if we could make them generic. However, this is currently not possible as some tests use the trait Ext as an object. Traits with generic functions are not object safe.

The obvious solution is to refactor the tests to no longer use Ext as an object. Maybe there are other solutions for removing the code duplication.

Assign to @pgherveou as soon as he is added to paritytech.
@athei athei added the Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. label Mar 14, 2023
@github-project-automation github-project-automation bot moved this to Backlog 🗒 in Smart Contracts Mar 14, 2023
@athei athei changed the title contracts: Refacor `Ext::*_storage_ contracts: Refactor Ext::*_storage_transparent functions Mar 14, 2023
@athei athei changed the title contracts: Refactor Ext::*_storage_transparent functions contracts: Refactor trait Ext::*_storage_transparent functions Mar 14, 2023
pgherveou added a commit that referenced this issue Mar 14, 2023
@pgherveou
merge _transparent methods
1751ddb 
fix #13594

typo fixes

remove _transparent methods
pgherveou added a commit that referenced this issue Mar 14, 2023
@pgherveou
merge _transparent methods
ed99b95 
fix #13594

typo fixes

remove _transparent methods
@pgherveou pgherveou mentioned this issue Mar 14, 2023
Merged
@github-project-automation github-project-automation bot moved this from Backlog 🗒 to Done ✅ in Smart Contracts Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pgherveou pgherveou

Labels
Z2-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Projects
Smart Contracts
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

contracts: Refactor trait Ext::*_storage_transparent functions paritytech/substrate
2 participants
@pgherveou @athei