This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Update node-template construct_runtime! syntax
#10155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuke-web3
added
B0-silent
nuke-web3
commented
Nov 2, 2021
| @@ -150,5 +150,6 @@ fn testnet_genesis( | |||
| // Assign network admin rights. | |||
| key: root_key, | |||
| }, | |||
| transaction_payment: Default::default(), | |||
There was a problem hiding this comment.
Was this somehow missed? I could not build https://github.com/paritytech/substrate/tree/monthly-2021-11 out of the box 😬
Is Default correct to use?
There was a problem hiding this comment.
yes below in transaction payment we don't write the Config part, thus the genesis config of transaction payment is not included.
You can either do exclude_part { Config } or do as you did (which I think is better)
bkchr
approved these changes
Nov 2, 2021
gui1117
approved these changes
Nov 4, 2021
|
bot merge |
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* update `construct_runtime!` syntax * fix build
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* update `construct_runtime!` syntax * fix build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #9681, the
construct_runtime!section can now just specify the pallets, and no need to concretely set the generics they need for the template.I will create a new tag for this for the downstream template (monthly-2021-11+1)I would like to move the pre-release tag (as the build was broken for the tag as it is now) to include it in updating it for the monthly release https://github.com/substrate-developer-hub/substrate-node-template/issues/258No need to change tags, it will just be included in the template downstream ✔️