build: add rust-toolchain file #10607
Conversation
this file will specify the current nightly version we are targeting
|
AFAICT this is the current version we use in CI. |
andresilva
added
B0-silent
| @@ -0,0 +1,4 @@ | |||
| [toolchain] | |||
| channel = "nightly-2021-10-29" | |||
| components = [ "rustfmt" ] | |||
There was a problem hiding this comment.
do we want clippy in there?
There was a problem hiding this comment.
I seem to have clippy by default so looks like we don't need to explicitly include it.
|
Works on my nix box. I am all for this as it reduces the barriers for external contributors. |
There was a problem hiding this comment.
So compiles everything with the nightly compiler?
This is a changing behavior of the current way of building.
This file would also not be automatically changed when we add a new CI image.
Imo we should find a proper way on how we track the rust version entirely in git, aka dropping the installation of rust in the CI image for example and not start adding more and more locations that are loosely coupled.
| @@ -0,0 +1,4 @@ | |||
| [toolchain] | |||
| channel = "nightly-2021-10-29" | |||
There was a problem hiding this comment.
This isn't the version we use ci. This downloads its in every ci run.
There was a problem hiding this comment.
Yeah, I checked the CI logs to check for the version being used but blundered and copied the cargo nightly release date instead of rustc.
nightly-x86_64-unknown-linux-gnu (overridden by +toolchain on the command line)
rustc 1.58.0-nightly (46b8e7488 2021-11-07)
�[32;1m$ cargo +nightly --version�[0;m
cargo 1.58.0-nightly (94ca096af 2021-10-29)
Agreed, we probably need to settle on some standard for this. FWIW I'm in favor of just using one toolchain, i.e. either stable with RUSTC_BOOSTRAP hack, or just use nightly for everything.
Ideally the CI image would just read from this file (or some other file that comes from the repo). As an optimization the CI image could have the latest version already downloaded, but when this file changes it should download it always (until the image gets updated). I will close this for now. |
That already worked with your change here. I think we may could directly remove rust from the image. AFAIK all gha jobs also download rust in every run. |
|
Can substrate build on stable rust? I don't know why wasm-builder require a nightly version. |
|
See the tracking issue: #1252 |
This file will specify the current nightly version we are targeting and hopefully reduce the number of times we have to point people to use the correct compiler version. The
shell.nixwas updated to use this file.I have used the old format ofrust-toolchainsince the new TOML format is currently not supported by the rust nix overlay that we use inshell.nix.