This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add experimental support for QUIC #11514
Open
kpp
wants to merge
26
commits into
master
Choose a base branch
from
kpp-quic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
b448b6d
Patch libp2p
kpp bb7abd9
Build QUIC transport
kpp 450d260
Pass quic_port through cli args
kpp f052690
Build quic transport from cli args
kpp 4d61feb
Review fixes: ipv6 :: addr
kpp 5504f4c
Merge branch 'master' into kpp-quic
kpp f661801
Upgrade libp2p to 0.47.0
kpp 0b56dc1
Merge branch 'master' into kpp-quic
kpp 81bdbdf
upgrade libp2p to 0.50.0
melekes 21cf90c
on_swarm_event and on_connection_handler_event
melekes 8a227e4
replace `Swarm::new` with `Swarm::with_threadpool_executor`
melekes 8a97a52
on_swarm_event and on_connection_handler_event part 2
melekes e9b731b
on_swarm_event and on_connection_handler_event part 3
melekes d27d73a
on_swarm_event and on_connection_handler_event part 4
melekes 672cac2
update libp2p
melekes 41ab633
Merge branch 'master' into anton/upgrade-libp2p-to-0.50.0
melekes 2fa1b2b
libp2p 0.50.0
melekes b3c33b5
rename OutboundQueryCompleted to OutboundQueryProgressed
melekes 20437d7
remove unused var
melekes dbb7bec
accumulate outbound_query_records until query is finished
melekes bc53171
Merge branch 'anton/upgrade-libp2p-to-0.50.0' into kpp-quic
kpp 458c7aa
Use --experimental-quic flag for cli
kpp 46c473e
Merge branch 'master' into kpp-quic
kpp 1360b83
Review fixes
kpp fcc4b51
Update client/network/src/transport.rs
kpp 62ff75e
Merge branch 'master' into kpp-quic
kpp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it be better if we return
tcp_transport
without an OptionalTransport when quic is disabled? I.e. why wrap tcp_transport in OrTransport if we know quic is None.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's an experimental feature. Once it is stable there will be OrTransport without optional quic. And stabilization will require very little amount of changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the either way is OK.