-
Notifications
You must be signed in to change notification settings - Fork 2.6k
sp-beefy: align authority id key type with its signature type #13131
Conversation
Still allows custom message hasher, but ties together the crypto types used for private+public keys and the signature. Signed-off-by: acatangiu <[email protected]>
bot rebase |
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 (code-wise; don't know enough to reason about business logic)
This touches on the issue we were discussing few meetings ago. It is possible that when we have BLS and ECDAS keys then AuthorityId will not be the same thing as public key. Because the ECDSA key is enough to identify the validator and so we might need to include all BLS public keys arounds. Note that BLS public keys could be as large as 96Bytes and unifying AuthorityId and Public Key could potentially enlarge each beefy messages up to 100KB if they are included in the message as part of AuthorityId. On the other hand, as it came up in our last meeting, the keystore lacks the ability to associating different type of public keys with each other. So we might need that information to make tell keystore which BLS key of ours to use. Maybe we should discuss the issue tomorrow in our meeting. |
Still allows custom message hasher, but ties together the crypto types used for private+public keys and the signature. Signed-off-by: acatangiu <[email protected]>
…tech#13131) Still allows custom message hasher, but ties together the crypto types used for private+public keys and the signature. Signed-off-by: acatangiu <[email protected]>
…tech#13131) Still allows custom message hasher, but ties together the crypto types used for private+public keys and the signature. Signed-off-by: acatangiu <[email protected]>
Still allows custom message hasher, but ties together the crypto used for private+public keys type and the signature type.
Prerequisite for verifying equivocations in #13121