Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[contracts] rename call_runtime() returned error #13412

Merged
merged 1 commit into from
Feb 20, 2023
Merged

[contracts] rename call_runtime() returned error #13412

merged 1 commit into from
Feb 20, 2023

Conversation

agryaznov
Copy link
Contributor

Tiny change to make it possible for ink! side to stay consistent with the pallet in error names.

@agryaznov agryaznov added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Feb 17, 2023
@agryaznov agryaznov requested a review from athei as a code owner February 17, 2023 18:25
@agryaznov agryaznov mentioned this pull request Feb 17, 2023
Merged
@agryaznov agryaznov requested a review from xermicus February 17, 2023 18:30
athei
athei approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please not that the name is not part of the ABI between pallet and contracts. So this is not a breaking change.

@athei athei merged commit 1eff887 into master Feb 20, 2023
@athei athei deleted the ag-err-rename branch February 20, 2023 15:45
ltfschoen pushed a commit to ltfschoen/substrate that referenced this pull request Feb 22, 2023
@agryaznov @ltfschoen
rename call_runtime() returned error (paritytech#13412)
bd4e06f
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@agryaznov @ark0f
rename call_runtime() returned error (paritytech#13412)
00c80b0
Ank4n pushed a commit that referenced this pull request Feb 28, 2023
@agryaznov @Ank4n
rename call_runtime() returned error (#13412)
4f403cd
@kiltbot kiltbot mentioned this pull request Apr 3, 2023
Closed
ukint-vs pushed a commit to gear-tech/substrate that referenced this pull request Apr 10, 2023
@agryaznov @ukint-vs
rename call_runtime() returned error (paritytech#13412)
9b608ec
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@agryaznov @nathanwhit
rename call_runtime() returned error (paritytech#13412)
f23af54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xermicus xermicus xermicus approved these changes

@athei athei athei approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
Smart Contracts
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agryaznov @athei @xermicus