feat: Update primary Substrate Docker instructions. Remove and redirect legacy erroneous substrate-node-template Docker instructions

[ltfschoen]

• Description:

  • Previously PR fix: Fixes substrate-node-template docker issues #13039 proposed changes to support latest docker compose v2 and docker-compose v1.
  • Previous PR fix: Fixes substrate-node-template docker issues #13039 was to be merged into branch Update Template README #12741 but that has since been merged
  • The first commit in this PR restores legacy code for PR fix: Fixes substrate-node-template docker issues #13039 for legacy traceability, but in later commits most of the files were removed. Read on for the reason why....
  • In PR fix: Fixes substrate-node-template docker issues #13039 @ggwpez suggested only supporting the latest version of Docker, but that change has not yet been made since in PR Update substrate-node-template readme to add ./.local folder #12901 it was implied that we would instead redirect users to use the common Substrate Docker instructions https://github.com/paritytech/substrate/blob/master/docker/substrate_builder.Dockerfile that already also gives users the option to use the substrate-node-template. So rather than fixing these additional substrate-node-template Docker instructions, we'll actually be removing them and just redirecting users to the Substrate Docker instructions, which just uses docker (not docker-compose or docker compose), so we don't have that Docker Compose versioning issue anymore.
  • @bkchr reviewed PR Update substrate-node-template readme to add ./.local folder #12901 that proposed to update the substrate-node-tempate README to inform users to run mkdir ./.local before running the script ./scripts/docker_run.sh to avoid getting the error `Error response from daemon: invalid mount config for type "bind": bind source path does not exist: ~/substrate/bin/node-template/.local. That PR was closed in favour of encouraging users to instead use the Substrate docker instructions in https://github.com/paritytech/substrate/blob/master/docker/README.md so they use https://github.com/paritytech/substrate/blob/master/docker/substrate_builder.Dockerfile, and just tweak those instructions to use the node-template part of it, which makes the most sense. This change would go hand-in-hand with this PR fix: Fixes #13071 change order of ldd command and update ./docker/README.md #13072 that fixes a minor issue with the Substrate Dockerfile and updates the instructions.

• Related Issues: You mentioned a related issue if this PR is related to it, e.g. Fixes #228 or Related #1337.

  • Related fix: Fixes substrate-node-template docker issues #13039
  • Related fix: Fixes #13071 change order of ldd command and update ./docker/README.md #13072
  • Related Update Template README #12741
  • Related Update substrate-node-template readme to add ./.local folder #12901

• 2 Reviewers: You asked at least two reviewers to review. If you aren't sure, start with GH suggestions.

  • Suggest @bkchr and @nukemandan and @ggwpez to review

• Style Guide: Your PR adheres to the style guide

  • In particular, mind the maximal line length of 100 (120 in exceptional circumstances).
  • There is no commented code checked in unless necessary.
  • Any panickers in the runtime have a proof or were removed.

• N/A [X] Runtime Version: You bumped the runtime version if there are breaking changes in the runtime.

• N/A [X] Docs: You updated any rustdocs which may need to change.

• N/A [X] Polkadot Companion: Has the PR altered the external API or interfaces used by Polkadot?

  • N/A [X] If so, do you have the corresponding Polkadot PR ready?
  • N/A [X] Optionally: Do you have a corresponding Cumulus PR?

[ltfschoen]

I'm on a slow machine so it'll take a while to test before I create the PR.

Additional changes that could be made but are excluded from this PR are:

• Use a environment variable like DEBUG=true build.sh that gets passed as an argument into the Dockerfile to conditionally use cargo build --locked --release and target/release if DEBUG=false is provided, and otherwise use cargo build --locked and target/debug if its DEBUG=true is provided.

• Does not allow them to run the following too:

./run.sh cargo --version
./run.sh rustc --version
./run.sh rustup --version

I made an attempt at trying to get this to work in this commit 69de77d#diff-5ec7001467db95278ca884bf1446c5c3138d23ffd1a2938ac92adfe6c57cef51R39, but even though i build the image with changes in the 2nd build like updating the ssl ca certificates, installing relevant linker programs for rustc and substrate, installing rustup and only giving the substrate user permissions, and updating rustup default stable in the container and updating the $PATH with CARGO_HOME=$HOME/.cargo and RUSTUP_HOME=$CARGO_HOME/bin, when i tried to run those commands it'd give errors like info: no updatable toolchains installed error: rustup is not installed at '/root/.cargo' even though it had been added there.
an example was the following, even though i'd already installed rustup in the default directory in the 2nd build stage.

./run.sh rustup default nightly && rustc --version
*** Running Substrate Docker container with provided arguments: rustup default nightly

info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
warning: Signature verification failed for 'https://static.rust-lang.org/dist/channel-rust-nightly.toml'
info: latest update on 2023-02-25, rust version 1.69.0-nightly (c5c7d2b37 2023-02-24)
info: downloading component 'cargo'

Command 'rustc' not found, but can be installed with:
apt install rustc

without updating the ssl ca certificates in the container i'd get error like:

./run.sh rustup default stable
*** Running Substrate Docker container with provided arguments: rustup default stable

info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256' to '/substrate/.rustup/tmp/d5qo0tzv22ukcd44_file': failed to make network request: error sending request for url (https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256): error trying to connect: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:1921: (unable to get local issuer certificate): error trying to connect: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:1921: (unable to get local issuer certificate): error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:1921: (unable to get local issuer certificate): error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:1921:

and sometimes when i'd run ./run.sh rustup update even if rustup had been installed in 2nd stage of dockerfile, it'd give error:

info: no updatable toolchains installed
error: rustup is not installed at '/root/.cargo'

[bkchr]

Please remove

[ltfschoen]

i've removed that file now.
i checked it still builds successfully when i ran the following on ubuntu 22.04 LTS after removing that file:

cd bin/node-template && \
curl --proto '=https' --tlsv1.3 https://sh.rustup.rs -sSf | sh -s -- -y && \
. $HOME/.cargo/env && \
sudo apt install -y build-essential libclang-dev protobuf-compiler && \
rustup update nightly && \
rustup target add wasm32-unknown-unknown --toolchain nightly && \
cargo build --release

[bkchr]

@ltfschoen please merge master

[ltfschoen]

@ltfschoen please merge master

i've merged latest master and fixed conflicts

[dmitry-markin]

@ltfschoen thanks for contributing!