This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
im-online: don't disable offending validators #13493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
dmitry-markin
approved these changes
Mar 1, 2023
altonen
approved these changes
Mar 1, 2023
davxy
approved these changes
Mar 1, 2023
bkchr
approved these changes
Mar 1, 2023
|
bot merge |
ukint-vs
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Apr 10, 2023
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
Closed
46 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a validator commits an offence it gets kicked out of the validator set. On top of that, if the offence leads to a slash the validator will also get disabled, this means that even though the validator is part of the validator set, until the era ends when it should get kicked out, it cannot author new blocks. This PR changes the behavior for "offlineness" offences, such that even if the validator gets slashed it will not be disabled and thus can participate in consensus until the end of the era (when it should still get kicked out of the validator set).
For "offlineness" offences we only trigger slashing if more than 10% of the validator set is determined to be offline. I believe there is no advantage in disabling validators for "offlineness" since they're not actively trying to attack the protocol (unlike equivocations). In the case of a systemic issue that causes all validators to be considered offline (i.e. a bug) this would make it so that no one in the validator set can author new blocks and thus halt the chain.