Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix BASE lookup in cargo-check-benches #13620

Merged
merged 2 commits into from
Mar 16, 2023
Merged

fix BASE lookup in cargo-check-benches #13620

merged 2 commits into from
Mar 16, 2023

Conversation

altaua
Copy link
Contributor

@altaua altaua commented Mar 16, 2023

No description provided.

@altaua altaua added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 16, 2023
@altaua altaua requested a review from a team as a code owner March 16, 2023 12:42
@altaua altaua self-assigned this Mar 16, 2023
@paritytech-ci paritytech-ci requested a review from a team March 16, 2023 12:53
@altaua altaua added A0-please_review Pull request needs code review. and removed A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Mar 16, 2023
@altaua
Copy link
Contributor Author

altaua commented Mar 16, 2023

Noticed another bug in the old code (the fetch respecs were broken) and refactored the whole thing.

refactor cargo-check-benches logic
67c73fd 
* fix fetch refspec
* assume base is master if the api call fails
* merge master into pr branch rather than the other way around; same
  effect but imo cleaner and more readable
* don't re-fetch pr branch, we want to test the version our pipeline is
  running on
@altaua altaua force-pushed the mira/cargo-check-benches branch from ed90931 to 67c73fd Compare March 16, 2023 13:58
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2536936

@altaua
Copy link
Contributor Author

altaua commented Mar 16, 2023 •
edited
Loading

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2536936

^ just a rusty-cachier network fluke

@altaua altaua requested a review from alvicsam March 16, 2023 14:12
@altaua altaua merged commit 283106b into master Mar 16, 2023
@altaua altaua deleted the mira/cargo-check-benches branch March 16, 2023 14:57
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcny rcny rcny approved these changes

@alvicsam alvicsam Awaiting requested review from alvicsam

Assignees

@altaua altaua

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@altaua @paritytech-cicd-pr @rcny @alvicsam