Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

chore(sc-cli): improve runner and signals #13688

Merged
merged 3 commits into from
Mar 26, 2023
Merged

chore(sc-cli): improve runner and signals #13688

merged 3 commits into from
Mar 26, 2023

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Mar 23, 2023 •
edited
Loading

  • Make runner code more clear.
  • Improve the signals, now it could work well outside the sc-cli.

polkadot address: 15ouFh2SHpGbHtDPsJ6cXQfes9Cx1gEFnJJsJVqPGzBSTudr

bkchr
bkchr approved these changes Mar 23, 2023
View reviewed changes
client/cli/src/runner.rs Show resolved Hide resolved
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 23, 2023
@bkchr bkchr requested a review from a team March 23, 2023 09:13
@bkchr
Copy link
Member

bkchr commented Mar 23, 2023

/tip small

@substrate-tip-bot
Copy link

@bkchr A small tip was successfully submitted for yjhmelody (15ouFh2SHpGbHtDPsJ6cXQfes9Cx1gEFnJJsJVqPGzBSTudr on polkadot).

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips tip

@bkchr
Copy link
Member

bkchr commented Mar 26, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit aeefc8b into paritytech:master Mar 26, 2023
@yjhmelody yjhmelody deleted the chore-sc-cli-signals branch March 27, 2023 15:15
gpestana pushed a commit that referenced this pull request Apr 23, 2023
@yjhmelody @bkchr @gpestana
chore(sc-cli): improve runner and signals (#13688)
a483470 
* chore(sc-cli): improve runner and signals

* Update client/cli/src/runner.rs

* fmt

---------

Co-authored-by: Bastian Köcher <[email protected]>
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@yjhmelody @bkchr @nathanwhit
chore(sc-cli): improve runner and signals (paritytech#13688)
df8cb02 
* chore(sc-cli): improve runner and signals

* Update client/cli/src/runner.rs

* fmt

---------

Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davxy davxy davxy approved these changes

@bkchr bkchr bkchr approved these changes

@skunert skunert skunert approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yjhmelody @bkchr @skunert @davxy