This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
added
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
D9-needsaudit 👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
B1-note_worthy
Changes should be noted in the release notes
T1-runtime
This PR/Issue is related to the topic “runtime”.
labels
Mar 31, 2023
jsidorenko
reviewed
Apr 4, 2023
Co-authored-by: Jegor Sidorenko <[email protected]>
Could you pls sync your branch with master? |
jsidorenko
approved these changes
Apr 14, 2023
bot rebase |
Rebased |
ggwpez
approved these changes
Apr 14, 2023
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/april-updates-for-substrate-and-polkadot-devs/2764/1 |
louismerlin
added
D1-audited 👍
PR contains changes to fund-managing logic that has been properly reviewed and externally audited
and removed
D9-needsaudit 👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
labels
May 4, 2023
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Add Freeze/Thaw events and tests * Remove duplicate docstring * Correct spelling error * Cargo fmt * Use proper punctuation in docstring Co-authored-by: Jegor Sidorenko <[email protected]> --------- Co-authored-by: Jegor Sidorenko <[email protected]> Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B1-note_worthy
Changes should be noted in the release notes
C1-low
PR touches the given topic and has a low impact on builders.
D1-audited 👍
PR contains changes to fund-managing logic that has been properly reviewed and externally audited
T1-runtime
This PR/Issue is related to the topic “runtime”.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Freeze
andThaw
event. The respective event is emitted whenever some balance is frozen or thawed. This is a continuation of #12287. I decided to split PRs to maintain transparency and to not invalidate the previous audit, see #12287 (comment) for more information.The logic remained the same as in #12287, however two new events
Freeze
andThaw
were added that cover the case thatupdate_freezes
is invoked instead of the deprecatedupdate_locks
. The tests are also equal, except that the calls were adjusted to thefreeze
case. Those are the test scenarios:I decided to follow the approach of adding new events for functionality added in the
Fungible
implementation. Now aLock
andUnlock
event exists for calls into the deprecatedupdate_locks
, whereasFreeze
andThaw
also exist to cover calls into the newupdate_freezey
function. Should we move forward with that approach?