Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Force upgrade snow to 0.9.2 #13806

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Force upgrade snow to 0.9.2 #13806

merged 1 commit into from
Apr 3, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Apr 3, 2023

This fixes the compilation on master for the node template that was not pulling the latest release as part of its build.

@bkchr
Force upgrade snow to 0.9.2
b4a9aab 
This fixes the compilation on master for the node template that was not pulling the latest release
as part of its build.
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 3, 2023
niklasad1
niklasad1 approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, but can't you just do cargo update -p snow to update Cargo.lock to enforce that?

@bkchr
Copy link
Member Author

bkchr commented Apr 3, 2023

Fine for me, but can't you just do cargo update -p snow to update Cargo.lock to enforce that?

No, the node-template release script isn't using the Cargo.lock from Substrate. It generates a new one.

@bkchr bkchr merged commit be9fa62 into master Apr 3, 2023
@bkchr bkchr deleted the bkchr-fix-master branch April 3, 2023 09:37
gpestana pushed a commit that referenced this pull request Apr 23, 2023
@bkchr @gpestana
Force upgrade snow to 0.9.2 (#13806)
e1b12eb 
This fixes the compilation on master for the node template that was not pulling the latest release
as part of its build.
@kacperzuk-neti kacperzuk-neti mentioned this pull request Jun 23, 2023
Merged
15 tasks
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@bkchr @nathanwhit
Force upgrade snow to 0.9.2 (paritytech#13806)
be82359 
This fixes the compilation on master for the node template that was not pulling the latest release
as part of its build.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

@cheme cheme cheme approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkchr @cheme @niklasad1 @acatangiu