This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Emit events related to asset mutations #14099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
bkchr
approved these changes
May 9, 2023
joepetrowski
approved these changes
May 9, 2023
sam0x17
approved these changes
May 9, 2023
Hah, apparently one of the unit tests were failing even before my changes, and we weren't testing the scenario properly. Good thing you've asked! |
gilescope
approved these changes
May 9, 2023
|
bot merge |
|
Error: Response error (status 500 Internal Server Error): |
|
bot merge |
chevdor
pushed a commit
that referenced
this pull request
May 9, 2023
* Emit events related to asset mutations * Fixes * Improve unit tests * cargo fmt
Merged
bkchr
pushed a commit
that referenced
this pull request
May 10, 2023
* Emit events related to asset mutations * Fixes * Improve unit tests * cargo fmt Co-authored-by: Keith Yeung <[email protected]>
chevdor
pushed a commit
that referenced
this pull request
May 10, 2023
* Emit events related to asset mutations * Fixes * Improve unit tests * cargo fmt
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Emit events related to asset mutations * Fixes * Improve unit tests * cargo fmt
vanderian
pushed a commit
to gasp-xyz/substrate
that referenced
this pull request
Jul 26, 2023
…#14102) * Emit events related to asset mutations * Fixes * Improve unit tests * cargo fmt Co-authored-by: Keith Yeung <[email protected]>
Open
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of the XCM integration tests, it was discovered that the
fungibles::regular::Mutate::transferimplementation of the Assets pallet didn't fire off any events, causing the test to fail, but the asset to actually be transferred. This PR aims to make sure that all asset mutation events properly fire off the associated events.