Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade version for exjsx and excoveralls #115

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Upgrade version for exjsx and excoveralls #115

merged 1 commit into from
Jul 18, 2017

Conversation

vinhnglx
Copy link
Contributor

Hello guys,

I would like to upgrade the version for ExJSX from 3.2 to 4.0. They replace HashDict with Mapset.
(Reference link: talentdeficit/exjsx#40)

This is my first PR for Elixir-OSS. So, please let me know if my PR is wrong.

Thanks,
Vincent Ng

@coveralls
Copy link

coveralls commented Jul 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 92.936% when pulling 68686b0 on vinhnglx:master into 07c54d9 on parroty:master.

@parroty parroty merged commit b4d0c53 into parroty:master Jul 18, 2017
@parroty
Copy link
Owner

parroty commented Jul 18, 2017 •
edited
Loading

Thanks. I hadn't been able to catch up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinhnglx @coveralls @parroty