Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_localhost config option #133

Merged
merged 1 commit into from
Apr 15, 2018

Conversation

joecorkerton
Copy link
Contributor

Allows users to set the ignore_localhost config option so that exvcr does not record localhost calls. This could be extended in the future to allow users to specify custom domains they wish to ignore.

Use case for this feature - I am trying to write some feature tests with hound. My app calls out to a third party service for some data. I would like to stub this request with VCRs so that my tests pass on CI, but I do not want to stub all of the localhost requests I am making to the headless browser

@coveralls
Copy link

coveralls commented Apr 8, 2018

Coverage Status

Coverage increased (+0.1%) to 93.802% when pulling ed87bdc on joecorkerton:ignore-requests into fdf5988 on parroty:master.

@parroty parroty merged commit aebf1be into parroty:master Apr 15, 2018
@parroty
Copy link
Owner

parroty commented Apr 15, 2018

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants