Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation in project lacking Finch #205

Merged
merged 1 commit into from
May 13, 2023
Merged

Fix compilation in project lacking Finch #205

merged 1 commit into from
May 13, 2023

Conversation

nonninz
Copy link
Contributor

@nonninz nonninz commented May 12, 2023

This PR wraps lib/exvcr/adapter/finch/converter.ex in a if Code.ensure_loaded?(Finch) do block.

Closes #204

@coveralls
Copy link

coveralls commented May 13, 2023 •
edited
Loading

Coverage Status

Coverage: 89.907% (+1.4%) from 88.474% when pulling e6858b8 on nonninz:fix_compilation_without_finch into 15debf0 on parroty:master.

@parroty
Copy link
Owner

parroty commented May 13, 2023

Thanks for the PR 🙇.
#197 does not change the lib/exvcr/adapter/finch/converter.ex and I am not confident enough about how this change triggered this error yet. But applying Code.ensure_loaded?(Finch) as similar as lib/exvcr/adapter/finch.ex would make sense.

@parroty parroty merged commit 9284711 into parroty:master May 13, 2023
@parroty
Copy link
Owner

parroty commented May 13, 2023

Released as v0.14.1 and tested on extwitter project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 0.14.0 cannot be compiled in projects not using Finch
3 participants
@nonninz @coveralls @parroty