Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elixir 1.14 warnings #207

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Conversation

wpiekutowski
Copy link
Contributor

@wpiekutowski wpiekutowski commented Jul 26, 2023

This PR fixes all warnings emitted by Elixir 1.14.5 (Erlang 25). Probably should be squashed during merge.

warning: use Mix.Config is deprecated. Use the Config module instead
  config/config.exs:1
warning: :hackney_request.encode_form/1 defined in application :hackney is used by the current application but the current application does not depend on :hackney. To fix this, you must do one of:

  1. If :hackney is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :hackney is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :hackney, you may optionally skip this warning by adding [xref: [exclude: [:hackney_request]]] to your "def project" in mix.exs

  lib/exvcr/adapter/hackney/converter.ex:104: ExVCR.Adapter.Hackney.Converter.parse_request_body/1

@barttenbrinke
Copy link

warning: :hackney_request.encode_form/1 defined in application :hackney is used by the current application but the current application does not depend on :hackney. To fix this, you must do one of:

  1. If :hackney is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :hackney is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :hackney, you may optionally skip this warning by adding [xref: [exclude: [:hackney_request]]] to your "def project" in mix.exs

  lib/exvcr/adapter/hackney/converter.ex:104: ExVCR.Adapter.Hackney.Converter.parse_request_body/1
  

This still needs to be done, right?

@coveralls
Copy link

Coverage Status

coverage: 92.391% (+2.3%) from 90.062% when pulling 469651a on amberbit:fix/elixir-1-14-warnings into 93cb91a on parroty:master.

@wpiekutowski
Copy link
Contributor Author

@barttenbrinke @parroty Both warnings are taken care of. PR is ready for review.

@parroty parroty merged commit 83a0b3e into parroty:master Jul 31, 2023
@parroty
Copy link
Owner

parroty commented Jul 31, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants