Fix tests that are failing the build #5551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking about doing the same thing |
|
The test didn't pass though... I will try to figure out. |
davimacedo
changed the title
|
There was another test failing with the same problem. All tests are passing now. |
|
Are there more like that? We can probably get rid of the |
|
The problem here is actually the way the sort callback is written. I didn't find more cases like this. In terms of deep-diff, there are many tests that use this package. They are passing but I agree with you that we could replace it. Maybe on a separate PR? |
dplewis
approved these changes
May 1, 2019
Merged
dplewis
added a commit
that referenced
this pull request
Jun 11, 2019
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
Closes: parse-community#5651 Building on parse-community#5551
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is the way that the arrays are sorted:
nodejs/node#24106