-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump chart dependencies and set defaults for KUBECTL_CMD for multiarch execution. Fixes #94 #95
base: main
Are you sure you want to change the base?
Conversation
Remove default value of KUBECTL_CMD because it is architecture-dependant (amd64).
Hello! Could you review and fix the unit/integration tests errors? The upgrade of those dependencies is breaking the testing suite. |
I think the unit/integration test errors are already in your codebase and not because of the upgrade of the dependencies (at least some of them). I have run the tests with a single change in the README.md here https://github.com/cgiraldo/charts-passbolt/actions/runs/12387964061 and they are failing. |
Hi @cgiraldo! Long time no see! Thanks for the contribution and the report. Indeed the tests were failing as helm charts unittest got a new release that surfaced some flaky tests in our chart. We have updated the tests in main so you can rebase your PR. |
Hi @dlen! I didn't notice who you were! What small world ;)! Let's see if now the tests pass. |
Very small indeed! Looks like there are still some issues apparently due to the last release @Tecnobutrul could you take a look? |
Hello! The unit test errors seem related to this new feature on bitnami charts. We will have to add the mentioned (on the "Can I skip the security verification?" section of the issue) flag when testing the override images for redis and mariadb. |
@Tecnobutrul , I added the flag to the unittests with errors. Now they are passing in my local tests. |
Thanks a lot! This will be part of the next release which we are going to release very soon. |
Remove default value of KUBECTL_CMD because it is architecture-dependant (amd64).