Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in en_UK source translation #517

Closed
mvdberge opened this issue May 30, 2024 · 2 comments
Closed

Error in en_UK source translation #517

mvdberge opened this issue May 30, 2024 · 2 comments
Assignees
@ishanvyas22

Comments

@mvdberge
Copy link

While translating parts of passbolt to German, I stumbled across the following line:

passbolt_api/resources/locales/en_UK/default.po

Line 1463 in 727e938

msgid "The database schema up to date."

I think it misses the word "is" and therefore should be
"The database schema is up to date."

Not sure how to handle this correctly, other than filing an issue. ;-)
@ishanvyas22
Copy link
Member

Thanks for bringing it to our attention, we will take care of it 🙏🏼 (ticket for internal ref. PB-33664)

@ishanvyas22 ishanvyas22 self-assigned this May 30, 2024
dlen pushed a commit that referenced this issue Jul 15, 2024
@ishanvyas22
PB-33664 Fix missing "is" in the database schema up to date sentence …
7be983c 
…(GITHUB #517)
dlen pushed a commit that referenced this issue Jul 15, 2024
@pabloelcolombiano
Merge branch 'feature/PB-33664_Fix-missing-is-in-the-database-schema-…
b9702b8 
…up-to-date-sentence-GITHUB-517' into 'common'

PB-33664 Fix missing "is" in the database schema up to date sentence (GITHUB #517)

See merge request passbolt/passbolt-pro-api!1626
dlen pushed a commit that referenced this issue Jul 15, 2024
@pabloelcolombiano
Merge branch 'passbolt-pro-api/common' into feature/PB-33992_Release-…
a727aaa 
…v490

* passbolt-pro-api/common: (31 commits)
  PB-34068 Styleguide version bump to v4.9.0
  PB-33813 Add limit to search-aros.json endpoint
  PB-33936 Add has-users filter to Gpgkeys index endpoint
  PB-33852 Fixes a bug and extends code coverage
  Draft: PB-33826 Improve performance of resources.json by using a custom iso format mapper
  PB-33650 Review, make BelongsToManyWithoutJunctionProperty core with PassboltBelongsToMany, allow developers to exclude the joint property based on optoin
  PB-33852 As a user requesting folderizable data I should not see the personal property for entities with no folder relations
  PB-33639 Performance: share/searchAros.json should support contain required browser extension
  PB-33702 Improve has-access filter performance on users.json
  PB-33747 Fix command injections vulnerabilities in composer/composer package
  PB-33692 Bump enygma/yubikey to v3.8
  PB-33692 Fix error shown after sign-in with MFA and Yubikey
  PB-33650 [CE] Adds the class BelongsToManyWithoutJunctionProperty
  PB-32591 Validate passbolt.plugins.smtpSettings.security configuration values before passing it to SMTP server
  PB-33688 [CE] Make filter method on permissions public
  PB-33690 Add index to gpgkeys.user_id column
  PB-33653 Improves performance when requesting multifactor authentification properties of users
  PB-24995 Improve last_logged_in query performance to reduce response time of users.json endpoint
  PB-33664 Fix missing "is" in the database schema up to date sentence (GITHUB #517)
  PB-33616 As a user adding a resource I should get a validation error if the secret is a string and not an array
  ...
@ishanvyas22
Copy link
Member

Hey @mvdberge, the typo has been fixed with v4.9 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ishanvyas22 ishanvyas22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvdberge @ishanvyas22