[CI] Update GitHub Actions to fix deprecation warnings #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MWin123
force-pushed
the
feature/update-actions
branch
from
7321ebf
to
ce5c07e
Compare
MWin123
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This fixes the deprecation warnings as described in #65.
I just increased the version of each GitHub Action to the latest stable one. I assumed that they didn't include any breaking changes without making it obvious in the README but I might be wrong.
It passed with this CI runner but apparently the commit didn't retain the Git tag in the PR? I guess that's working as intended because you don't want to create releases from PRs. I already increased the minor version in the
build.gradleto2.10.0. While CI passed, it didn't run all updated GitHub Actions because some require a release from a tagged commit.All deprecation warnings disappared as well: https://github.com/patschuh/KafkaEsque/actions/runs/9508209353
One unrelated one is left, it seems like this is a minor bug where tries to use
tar(instead ofzip?) on Windows.I'd probably just try it out by merging the PR, worst case is you have to revert that one commit. Don't forget to add the Git tag for
v2.10.0to create a release so it runs all updated GitHub ActionslCI on forks (help required, low prio)
I currently don't have the correct setup for all actions, e.g., the "Create release" step fails. I think it required an env variable and/or env secret but I'm not sure what exactly you had to do.
See https://github.com/MWin123/KafkaEsque/actions/runs/9507785065/job/26207904249 where it fails in that step.
@patschuh do you still remember what was required? If yes, could you please PM me a screenshot of the correct env vars and required permissions from the repo's setting?