Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter each engine to spawn its head and foot pattern into _meta/ if not found #611

Closed
4 of 6 tasks
bmuenzenmeyer opened this issue Feb 6, 2017 · 4 comments
Closed
4 of 6 tasks

Alter each engine to spawn its head and foot pattern into _meta/ if not found #611

bmuenzenmeyer opened this issue Feb 6, 2017 · 4 comments
Assignees
@bmuenzenmeyer
Labels
help wanted 🆘
Milestone
3.0.0

Comments

@bmuenzenmeyer
Copy link
Member

bmuenzenmeyer commented Feb 6, 2017 •
edited
Loading

part of #603
@bmuenzenmeyer bmuenzenmeyer added this to the 3.0.0 milestone Feb 6, 2017
@bmuenzenmeyer bmuenzenmeyer mentioned this issue Feb 6, 2017
Closed
9 tasks
@bmuenzenmeyer bmuenzenmeyer mentioned this issue Apr 10, 2017
Open
@bmuenzenmeyer bmuenzenmeyer self-assigned this Apr 10, 2017
@labbydev labbydev mentioned this issue Apr 12, 2017
Closed
@bmuenzenmeyer bmuenzenmeyer mentioned this issue May 4, 2017
Closed
bmuenzenmeyer added a commit that referenced this issue May 16, 2017
@bmuenzenmeyer
call spawnMeta if defined on the engine
0098d89 
part of #611
bmuenzenmeyer added a commit to pattern-lab/patternengine-node-mustache that referenced this issue May 16, 2017
@bmuenzenmeyer
spawn mustache meta patterns if not found
fc67592 
part of pattern-lab/patternlab-node#611
@bmuenzenmeyer bmuenzenmeyer mentioned this issue May 16, 2017
Merged
bmuenzenmeyer added a commit to pattern-lab/patternengine-node-handlebars that referenced this issue May 16, 2017
@bmuenzenmeyer
spawn handlebars meta patterns if not found
3dd846b 
part of pattern-lab/patternlab-node#611
bmuenzenmeyer added a commit to pattern-lab/patternengine-node-twig that referenced this issue May 16, 2017
@bmuenzenmeyer
spawn twig meta files if not found
c53cadd 
part of pattern-lab/patternlab-node#611
@bmuenzenmeyer
Copy link
Member Author

would be great if anyone else could help me understand what Underscore or React expect for these patterns

@bmuenzenmeyer
Copy link
Member Author

paging @geoffp - we discussed this what feels like ages ago, but can you ping me where I can find the underscore meta patterns?

@geoffp
Copy link
Contributor

geoffp commented Aug 16, 2017

@bmuenzenmeyer actually, I don't think we ever made any. It looks like in our underscore project, we're still using the default-ish mustache meta patterns, even though underscore is the main engine in use.

bmuenzenmeyer added a commit to pattern-lab/patternengine-node-underscore that referenced this issue Sep 17, 2017
@bmuenzenmeyer
spawn handlebars meta patterns if not found
e5e384a 
part of pattern-lab/patternlab-node#611
@freshdevelop freshdevelop mentioned this issue Oct 4, 2017
Closed
@bmuenzenmeyer bmuenzenmeyer mentioned this issue Nov 15, 2017
Open
@bmuenzenmeyer
Copy link
Member Author

Calling this done. future react work will need to account for this.

geoffp pushed a commit that referenced this issue Feb 23, 2018
@bmuenzenmeyer @geoffp
spawn mustache meta patterns if not found
0aeab24 
part of #611
geoffp pushed a commit that referenced this issue Feb 23, 2018
@bmuenzenmeyer @geoffp
spawn twig meta files if not found
b44ec0b 
part of #611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmuenzenmeyer bmuenzenmeyer

Labels
help wanted 🆘
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@geoffp @bmuenzenmeyer