Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load engines flexibly from either the current directory's node_modules #342

Merged
merged 1 commit into from
Jun 3, 2016

Conversation

geoffp
Copy link
Contributor

@geoffp geoffp commented Jun 1, 2016

@bmuenzenmeyer, check this out.

This should let us load engines from the core, or from whatever the "current" directory is. This isn't a perfect solution yet, because aside from checking the core, it assumes that the you're launching grunt/gulp/nodeunit/whatever from the root of your edition and looks for engine modules there. Has anyone ever not done it that way? Should we be more rigorous?

@bmuenzenmeyer bmuenzenmeyer merged commit bd16153 into dev-2.0-core Jun 3, 2016
@bmuenzenmeyer bmuenzenmeyer deleted the flexible-engine-loading branch June 3, 2016 09:43
@bmuenzenmeyer
Copy link
Member

Nice work Geoff!

@bmuenzenmeyer
Copy link
Member

Has anyone ever not done it that way? Should we be more rigorous?

To answer your questions - no one has ever done what we are doing. Doesn't that sound dramatic! Using PL/Node core with a dependency + editions is new to the Node community, but the consumption patterns we are laying down cowpaths for now make a lot of sense, both for standalone (and perhaps) dependency consumption that we haven't imagined yet. We'll have to see I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants