Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine hooks for file writing #542

Merged
merged 3 commits into from
Oct 28, 2016
Merged

Conversation

geoffp
Copy link
Contributor

@geoffp geoffp commented Oct 23, 2016

Addresses #541

Summary of changes:

  • Ask the linter to tolerate es6 syntax; all the es6 syntax herein was chosen to be compatible back to Node 4.4
  • Factor out writePatternFiles()
  • Preserve the current scheme as the default formatter, and provide hooks for engines to be able to implement their own
  • Add a hook for engines to be able to add files to the output if they need to

Copy link
Member

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a very smart solution. Thanks Geoff!

@bmuenzenmeyer bmuenzenmeyer merged commit 0607e06 into dev Oct 28, 2016
@bmuenzenmeyer bmuenzenmeyer deleted the engine-hooks-for-file-writing branch October 28, 2016 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants