Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Lab Node 3.0.0 Alpha 1 #718

Merged
merged 131 commits into from
Oct 20, 2017
Merged

Pattern Lab Node 3.0.0 Alpha 1 #718

merged 131 commits into from
Oct 20, 2017

Conversation

bmuenzenmeyer
Copy link
Member

@bmuenzenmeyer bmuenzenmeyer commented Oct 18, 2017

🔥 🔥 🔥 INCOMING 🔥 🔥 🔥

Summary of changes: https://github.com/pattern-lab/patternlab-node/wiki/ChangeLog#v300 and then some

Closes #603
Closes #695
Closes #638
Closes #425

Remaining Code Items
Remaining Peripheral Items
  • Update Pattern Lab Node Core 3.0 #603
  • Provide examples
  • New Release Notes
  • Wiki doc review
    • new events
    • configuration
    • public API
  • break out watch from asset_copy to whichever extent possible
  • unit test coverage

For the Curious...

Provided you have the usual contents of an edition in your current working directory:

const config = require('./patternlab-config.json');
const patternlab = require('patternlab-node')(config);

// build, optionally watching or choosing incremental builds
patternlab.build({
  cleanPublic: true, 
  watch: true
});

// or build, watch, and then self-host
patternlab.serve({
  cleanPublic: true
});

Should you want to watch events... such as if you wish to further transform the output.

patternlab.serve(...);

patternlab.events.on('patternlab-asset-change', (data) => {
  console.log(data); // {file: 'path/to/file.css', dest: 'path/to/destination'}
});

patternlab.events.on('patternlab-pattern-change', (data) => {
  console.log(data); // {file: 'path/to/file.ext'}
});

patternlab.events.on('patternlab-global-change', (data) => {
  console.log(data); // {file: 'path/to/file.ext'}
});

geoffp and others added 30 commits November 13, 2016 22:29
apparently (hopefully) free of race conditions. Next up: the rendering
appear to be generating any visible pseudo patterns in the UI.
This lets us avoid sorting all patterns against order and name, which would comingle them.
Sorting by order and name is only for pattern subtypes currently.
…-lab/patternlab-node into async-building-fix-order

Conflicts:
	core/lib/pattern_assembler.js
part of #610
part of the merge of #608

most unit tests working, only a few left - due to me hanging a property off the engine that @geoffp was not doing.
still need to see how it behaves during actual builds
still reporitng quite a few handlebar tests broken
@coveralls
Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage decreased (-1.8%) to 70.141% when pulling 81ec3f2 on dev into 3cf5ed4 on master.

@bmuenzenmeyer bmuenzenmeyer self-assigned this Oct 18, 2017
@coveralls
Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage decreased (-1.8%) to 70.141% when pulling 90e06ee on dev into 3cf5ed4 on master.

@coveralls
Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage decreased (-1.8%) to 70.141% when pulling e9fb138 on dev into 3cf5ed4 on master.

@coveralls
Copy link

coveralls commented Oct 19, 2017

Coverage Status

Coverage decreased (-1.8%) to 70.141% when pulling 4855419 on dev into 3cf5ed4 on master.

@coveralls
Copy link

coveralls commented Oct 20, 2017

Coverage Status

Coverage decreased (-1.8%) to 70.141% when pulling 038af71 on dev into 3cf5ed4 on master.

@coveralls
Copy link

coveralls commented Oct 20, 2017

Coverage Status

Coverage decreased (-1.8%) to 70.141% when pulling 165f2d1 on dev into 3cf5ed4 on master.

feat(package): Add default theme config to patternlab-config.json
@coveralls
Copy link

coveralls commented Oct 20, 2017

Coverage Status

Coverage decreased (-1.8%) to 70.141% when pulling b0afce3 on dev into 3cf5ed4 on master.

fix(ui_builder): Removing redundant config.theme
@coveralls
Copy link

coveralls commented Oct 20, 2017

Coverage Status

Coverage decreased (-1.8%) to 70.17% when pulling 8f376e7 on dev into 3cf5ed4 on master.

@bmuenzenmeyer bmuenzenmeyer merged commit 704ce3e into master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants